ANDROID-16870 Filter correctly loggerazzi failures belonging to retried executions#13
Merged
ANDROID-16870 Filter correctly loggerazzi failures belonging to retried executions#13
Conversation
dpastor
requested review from
a team,
Copilot,
jeslat and
pmartinbTEF
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes loggerazzi failure reports to correctly filter out failure logs from retried test executions that eventually succeeded. The changes ensure that only failure logs matching the last recorded report are retained, preventing false positives in failure reporting.
Key changes:
- Consolidates filtering logic for both recorded and failure logs into a single method
- Implements cross-directory filtering to remove failure logs that don't correspond to the latest recorded execution
- Maintains synchronization between recorded and failure directories by using the same timestamp-based filtering
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
include-build/gradle-plugin/src/main/java/com/telefonica/loggerazzi/LoggerazziPlugin.kt
Show resolved
Hide resolved
include-build/gradle-plugin/src/main/java/com/telefonica/loggerazzi/LoggerazziPlugin.kt
Show resolved
Hide resolved
dpastor
commented
Sep 22, 2025
| deviceFileManager.pullFailuresLogs(absolutePath) | ||
| processAndFilterResults() | ||
| } | ||
| filterRecordedAndFailureResults(recordedFolderFile, failuresFolderFile) |
Author
There was a problem hiding this comment.
I'll move all fixes applied to snaptesting on a PR in that repo.
pmartinbTEF
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
ANDROID-16870
🥅 What's the goal?
failures reports are based on failure files extracted from the devices, in case a test is retried in the applications and it works on a second iteration, it should not be shown on the failures report.
🚧 How do we do it?
📘 Documentation changes?
🧪 How can I test this?